core: record item source spans in CellItem#6
Merged
Merged
Conversation
CellItem (and its Python mirror CellDerivedItem) now carries `span` — the byte range of the item's source segment within the raw cell text, before extractors: atomic content spans the whole text; delimited and compound segments keep the offsets the matcher already computed while splitting (adjusted for java_trim). Matching semantics are unchanged (pytest: 1908). Enables per-item highlighting in the vscode-rtl match preview (vscode-rtl plan §3.2 p. 5, §5.4). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
shigarov
added a commit
to regtab/vscode-rtl
that referenced
this pull request
Jul 12, 2026
…ined) Granularity changes from cells to cell-derived items: rtl/matchFixture now returns index, extracted string, tags and span (source segment range in the raw cell text, code-point units) per item, and the webview highlights those ranges inside the original cell text — a mixed cell [ATTR ":" VAL] shows a blue attribute segment and a green value segment with the delimiter dimmed. Segment tooltips carry role, tags and the extracted string. Uses the new CellItem.span from the pyregtab core (regtab/pyregtab#6, which this refinement added to plan §3.2 as item 5). Verified over stdio: compound, mixed-role and Cyrillic (byte→code-point conversion) cells. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CellItem(and its Python mirrorCellDerivedItem) now carriesspan— the byte range of the item's source segment within the raw cell text, before extractors:pos/end_pos), adjusted forjava_trim.Matching semantics are unchanged — the full pytest suite (1908) passes;
item_indexnumbering is preserved exactly (delimited: original part position incl. empty parts; compound: running index over non-empty parts).Enables per-item highlighting in the vscode-rtl match preview (its plan §3.2 p. 5, §5.4 pp. 2–3).
🤖 Generated with Claude Code